chore: Improve Request Screening (#101)

* open chat while screening

* close panel on ignore

* bypass screening

* .

* improve settings

* refine modal

* .

* .

* .

* .

* .

crates/ui/src/dock_area/mod.rs

@@ -3,8 +3,8 @@ use std::sync::Arc;
 use gpui::prelude::FluentBuilder;
 use gpui::{
     actions, canvas, div, px, AnyElement, AnyView, App, AppContext, Axis, Bounds, Context, Edges,
-    Entity, EntityId, EventEmitter, InteractiveElement as _, IntoElement, ParentElement as _,
-    Pixels, Render, Styled, Subscription, WeakEntity, Window,
+    Entity, EntityId, EventEmitter, Focusable, InteractiveElement as _, IntoElement,
+    ParentElement as _, Pixels, Render, Styled, Subscription, WeakEntity, Window,
 };
 
 use crate::dock_area::dock::{Dock, DockPlacement};
@@ -39,7 +39,7 @@ pub enum DockEvent {
 pub struct DockArea {
     pub(crate) bounds: Bounds<Pixels>,
     /// The center view of the dockarea.
-    items: DockItem,
+    pub items: DockItem,
     /// The entity_id of the [`TabPanel`](TabPanel) where each toggle button should be displayed,
     toggle_button_panels: Edges<Option<EntityId>>,
     /// The left dock of the dock_area.
@@ -73,7 +73,7 @@ pub enum DockItem {
         active_ix: usize,
         view: Entity<TabPanel>,
     },
-    /// Panel layout
+    /// Single panel layout
     Panel { view: Arc<dyn PanelView> },
 }
 
@@ -286,6 +286,12 @@ impl DockItem {
             DockItem::Panel { .. } => None,
         }
     }
+
+    pub(crate) fn focus_tab_panel(&self, window: &mut Window, cx: &mut App) {
+        if let DockItem::Tabs { view, .. } = self {
+            window.focus(&view.read(cx).focus_handle(cx));
+        }
+    }
 }
 
 impl DockArea {
@@ -572,12 +578,8 @@ impl DockArea {
                 }
             }
             DockPlacement::Center => {
-                let focus_handle = panel.focus_handle(cx);
-                // Add panel
                 self.items
                     .add_panel(panel, &cx.entity().downgrade(), window, cx);
-                // Focus to the newly added panel
-                window.focus(&focus_handle);
             }
         }
     }
@@ -707,6 +709,10 @@ impl DockArea {
             .and_then(|dock| dock.read(cx).panel.left_top_tab_panel(cx))
             .map(|view| view.entity_id());
     }
+
+    pub fn focus_tab_panel(&mut self, window: &mut Window, cx: &mut App) {
+        self.items.focus_tab_panel(window, cx);
+    }
 }
 
 impl EventEmitter<DockEvent> for DockArea {}

crates/ui/src/dock_area/tab_panel.rs

@@ -13,7 +13,6 @@ use super::panel::PanelView;
 use super::stack_panel::StackPanel;
 use super::{ClosePanel, DockArea, PanelEvent, PanelStyle, ToggleZoom};
 use crate::button::{Button, ButtonVariants as _};
-use crate::dock_area::dock::DockPlacement;
 use crate::dock_area::panel::Panel;
 use crate::popup_menu::{PopupMenu, PopupMenuExt};
 use crate::tab::tab_bar::TabBar;
@@ -454,89 +453,6 @@ impl TabPanel {
             )
     }
 
-    fn _render_dock_toggle_button(
-        &self,
-        placement: DockPlacement,
-        _window: &mut Window,
-        cx: &mut Context<Self>,
-    ) -> Option<impl IntoElement> {
-        if self.is_zoomed {
-            return None;
-        }
-
-        let dock_area = self.dock_area.upgrade()?.read(cx);
-
-        if !dock_area.is_dock_collapsible(placement, cx) {
-            return None;
-        }
-
-        let view_entity_id = cx.entity().entity_id();
-        let toggle_button_panels = dock_area.toggle_button_panels;
-
-        // Check if current TabPanel's entity_id matches the one stored in DockArea for this placement
-        if !match placement {
-            DockPlacement::Left => {
-                dock_area.left_dock.is_some() && toggle_button_panels.left == Some(view_entity_id)
-            }
-            DockPlacement::Right => {
-                dock_area.right_dock.is_some() && toggle_button_panels.right == Some(view_entity_id)
-            }
-            DockPlacement::Bottom => {
-                dock_area.bottom_dock.is_some()
-                    && toggle_button_panels.bottom == Some(view_entity_id)
-            }
-            DockPlacement::Center => unreachable!(),
-        } {
-            return None;
-        }
-
-        let is_open = dock_area.is_dock_open(placement, cx);
-
-        let icon = match placement {
-            DockPlacement::Left => {
-                if is_open {
-                    IconName::PanelLeft
-                } else {
-                    IconName::PanelLeftOpen
-                }
-            }
-            DockPlacement::Right => {
-                if is_open {
-                    IconName::PanelRight
-                } else {
-                    IconName::PanelRightOpen
-                }
-            }
-            DockPlacement::Bottom => {
-                if is_open {
-                    IconName::PanelBottom
-                } else {
-                    IconName::PanelBottomOpen
-                }
-            }
-            DockPlacement::Center => unreachable!(),
-        };
-
-        Some(
-            Button::new(SharedString::from(format!("toggle-dock:{placement:?}")))
-                .icon(icon)
-                .small()
-                .ghost()
-                .tooltip(match is_open {
-                    true => "Collapse",
-                    false => "Expand",
-                })
-                .on_click(cx.listener({
-                    let dock_area = self.dock_area.clone();
-                    move |_, _, window, cx| {
-                        _ = dock_area.update(cx, |dock_area, cx| {
-                            dock_area.toggle_dock(placement, window, cx);
-                        });
-                    }
-                })),
-        )
-    }
-
     fn render_title_bar(
         &self,
         state: &TabState,
@@ -1038,6 +954,7 @@ impl Render for TabPanel {
     fn render(&mut self, window: &mut Window, cx: &mut Context<Self>) -> impl gpui::IntoElement {
         let focus_handle = self.focus_handle(cx);
         let active_panel = self.active_panel(cx);
+
         let mut state = TabState {
             closable: self.closable(cx),
             draggable: self.draggable(cx),